Review Request 109451: Move fixx11h into KWindowSystem

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109451/#review29080
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On March 12, 2013, 11:05 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109451/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 11:05 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Fixx11h is a header which is mostly needed by KWindowSystem and in
> general by functionality using XLib. Because of that it makes more
> sense to have the header together with other X related headers in
> KWindowSystem.
> 
> At the same time the HAVE_X11 ifdef is dropped from the header. This
> is not needed as the header is only intended to be used if XLib is
> included. The check is moved to the user of the header which in most
> has the #include already in an #ifdef HAVE_X11 block.
> 
> More information in [1].
> 
> [1]: http://lists.kde.org/?l=kde-frameworks-devel&m=136298982111644&w=2
> 
> 
> Diffs
> -----
> 
>   kded/CMakeLists.txt f51b7db 
>   kdeui/CMakeLists.txt 42bd230 
>   kdeui/dialogs/kcupsoptionswidget_p.cpp 4be2276 
>   kdeui/dialogs/kdeprintdialog.cpp 4f1c8b7 
>   kdeui/tests/CMakeLists.txt a6ebae1 
>   kdeui/tests/fixx11h_test.cpp 5d3e467 
>   kdeui/tests/fixx11h_test2.cpp d01999b 
>   kdeui/util/fixx11h.h 77da0f8 
>   kfile/CMakeLists.txt 0f84995 
>   kfile/kurlnavigator.cpp e54e14f 
>   khtml/CMakeLists.txt 9c791cb 
>   khtml/test_regression_fontoverload.cpp 0492b63 
>   kinit/CMakeLists.txt 8f6fb06 
>   staging/kde4support/src/CMakeLists.txt 13a042b 
>   tier1/kwindowsystem/autotests/CMakeLists.txt e2a7f0c 
>   tier1/kwindowsystem/autotests/fixx11h_test.cpp PRE-CREATION 
>   tier1/kwindowsystem/autotests/fixx11h_test2.cpp PRE-CREATION 
>   tier1/kwindowsystem/src/CMakeLists.txt 41c40bb 
>   tier1/kwindowsystem/src/fixx11h.h PRE-CREATION 
>   tier1/kwindowsystem/src/fixx11h_p.h 79c73a0 
>   tier1/kwindowsystem/src/kwindowsystem_x11.cpp bd608ac 
>   tier1/kwindowsystem/src/netwm.h d309606 
> 
> Diff: http://git.reviewboard.kde.org/r/109451/diff/
> 
> 
> Testing
> -------
> 
> clean compile and install of frameworks
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130312/90b3ce09/attachment.html>