Review Request 109449: Remove KWindowSystem::doNotManage

Martin Gräßlin mgraesslin at kde.org
Tue Mar 12 11:53:30 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109449/
-----------------------------------------------------------

(Updated March 12, 2013, 12:53 p.m.)


Review request for KDE Frameworks.


Changes
-------

removed the method. Should not be merged before review 109282 is merged


Summary (updated)
-----------------

Remove KWindowSystem::doNotManage


Description
-------

This method used to do a D-Bus call to KWin which is not the way to
communicate with an X11 window manager. It is wrong on multiple levels as
explained in [1].
    
[1] http://lists.kde.org/?l=kde-frameworks-devel&m=135980316015660&w=2


Diffs (updated)
-----

  tier1/kwindowsystem/src/CMakeLists.txt 41c40bb 
  tier1/kwindowsystem/src/kwindowsystem.h 7719beb 
  tier1/kwindowsystem/src/kwindowsystem_mac.cpp dcfca05 
  tier1/kwindowsystem/src/kwindowsystem_win.cpp 20ebf32 
  tier1/kwindowsystem/src/kwindowsystem_x11.cpp bd608ac 

Diff: http://git.reviewboard.kde.org/r/109449/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130312/b6655d70/attachment.html>


More information about the Kde-frameworks-devel mailing list