Review Request 109449: Deprecate KWindowSystem::doNotManage and make it no-op

[Martin Gräßlin]

> On March 12, 2013, 10:04 a.m., Stephen Kelly wrote:
> > tier1/kwindowsystem/src/kwindowsystem.h, line 480
> > <http://git.reviewboard.kde.org/r/109449/diff/1/?file=119434#file119434line480>
> >
> >     Why not remove it completely?

I'm fine with removing it complete, but assumed that in general source compatibility would be preferred.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109449/#review29056
-----------------------------------------------------------


On March 12, 2013, 9:09 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109449/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 9:09 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> This method used to do a D-Bus call to KWin which is not the way to
> communicate with an X11 window manager. It is wrong on multiple levels as
> explained in [1].
>     
> [1] http://lists.kde.org/?l=kde-frameworks-devel&m=135980316015660&w=2
> 
> 
> Diffs
> -----
> 
>   tier1/kwindowsystem/src/CMakeLists.txt 41c40bb 
>   tier1/kwindowsystem/src/kwindowsystem.h 7719beb 
>   tier1/kwindowsystem/src/kwindowsystem_mac.cpp dcfca05 
>   tier1/kwindowsystem/src/kwindowsystem_win.cpp 20ebf32 
>   tier1/kwindowsystem/src/kwindowsystem_x11.cpp bd608ac 
> 
> Diff: http://git.reviewboard.kde.org/r/109449/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130312/03280a68/attachment.html>