Review Request 111298: Add a URL handler for help:/// urls

[David Gil Oliva]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111298/#review35245
-----------------------------------------------------------



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25808>

    Q_OBJECT should be indented



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25815>

    QObject* parent -> QObject *parent



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25809>

    Spurious whitespace



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25813>

    const QString& dir -> const QString &dir



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25814>

    QLatin1String -> QStringLiteral



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25811>

    I think it should be a QStringLiteral instead of a QLatin1String



staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp
<http://git.reviewboard.kde.org/r/111298/#comment25810>

    Spurious whitespace


- David Gil Oliva


On June 28, 2013, 5:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111298/
> -----------------------------------------------------------
> 
> (Updated June 28, 2013, 5:14 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Following a task in the kdelibs_cleanup Epics, make it so Qt can properly open help:// urls.
> 
> I added some "magic" query arguments so we can be passed the application in case we want to deprecate KHelpClient::invokeHelp, I'm unsure if we should port the invokeHelp code to call this.
> 
> 
> Diffs
> -----
> 
>   staging/frameworkintegration/src/integrationplugin/frameworkintegrationplugin.cpp b8f5fa7 
> 
> Diff: http://git.reviewboard.kde.org/r/111298/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130628/6e7b4a1a/attachment-0001.html>