Review Request 111232: move klineedit and kcompletionbox to KCompletion framework
Commit Hook
null at kde.org
Thu Jun 27 21:04:46 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111232/
-----------------------------------------------------------
(Updated June 27, 2013, 9:04 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks, David Faure and Kevin Ottens.
Description
-------
move klineedit and kcompletionbox to KCompletion framework
Notes:
KIconTheme::assignIconsToContextMenu( KIconTheme::TextEditor, popup->actions () ) removed because there is task in Qt5 Epics (Add icons to QLineEdit context menu (via qstyle?)).
Can we cut dependency do KIconThemes too?
Diffs
-----
staging/kde4attic/src/CMakeLists.txt 0cf1be7
staging/kcompletion/tests/CMakeLists.txt e8e39f3
staging/kcompletion/src/config-kcompletion.h.cmake PRE-CREATION
staging/kcompletion/src/CMakeLists.txt e502554
staging/kcompletion/autotests/CMakeLists.txt f497c9a
security/crypto/CMakeLists.txt e890d33
kutils/CMakeLists.txt bfe8541
kross/ui/CMakeLists.txt 65e1abb
knewstuff/knewstuff3/CMakeLists.txt 41ea203
kioslave/http/kcookiejar/CMakeLists.txt 2dae665
kfile/CMakeLists.txt bc48bf7
kdeui/widgets/klineedit_p.h 7c58f2d
kdeui/widgets/klineedit.cpp 24920a8
kdeui/widgets/klineedit.h 7ac22f6
kdeui/widgets/kcompletionbox.cpp
kdeui/widgets/kcompletionbox.h 6e10dcf
kdeui/tests/klineedittest.cpp
kdeui/tests/klineedittest.h
kdeui/tests/klineedit_unittest.cpp
kdeui/tests/CMakeLists.txt fd8aa7b
kdeui/CMakeLists.txt 6d79682
staging/kde4support/src/CMakeLists.txt 551181c
staging/kemoticons/tests/CMakeLists.txt 3c59e7e
Diff: http://git.reviewboard.kde.org/r/111232/diff/
Testing
-------
it builds
Thanks,
Wojciech Kapuscinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130627/e674f30d/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list