Review Request 111250: Move KAssistantDialog to KWidgetsAddons

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111250/#review35102
-----------------------------------------------------------



kdeui/dialogs/kassistantdialog.h
<http://git.reviewboard.kde.org/r/111250/#comment25682>

    Interesting typo insertion. :-)



kdeui/dialogs/kassistantdialog.cpp
<http://git.reviewboard.kde.org/r/111250/#comment25683>

    At that point it's even faster and more readable to use setIcon and setText directly.



kdeui/dialogs/kassistantdialog.cpp
<http://git.reviewboard.kde.org/r/111250/#comment25684>

    Same here, use setIcon directly on the button.


- Kevin Ottens


On June 26, 2013, 9:14 a.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111250/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 9:14 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KAssistantDialog to KWidgetsAddons
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt 150ec0a 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 2757be6 
>   kdeui/tests/kassistantdialogtest.cpp 655169d 
>   kdeui/tests/CMakeLists.txt 2dd4079 
>   kdeui/dialogs/kassistantdialog.h 5f68d7d 
>   kdeui/dialogs/kassistantdialog.cpp bb5157d 
>   kdeui/CMakeLists.txt 3946ebf 
> 
> Diff: http://git.reviewboard.kde.org/r/111250/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130626/3a3ca6e1/attachment.html>