Review Request 111246: Port time_t to QDateTime in Ftp (kioslave)

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111246/#review35092
-----------------------------------------------------------



kioslave/ftp/ftp.cpp
<http://git.reviewboard.kde.org/r/111246/#comment25677>

    Casting a const char* to int looks wrong... it should probably still be atoi here or something equivalent.


- Kevin Ottens


On June 25, 2013, 9:56 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111246/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 9:56 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in Ftp (kioslave)
> 
> It was less work than previously thought. Nevertheless, I won't substitute
> the const *chars to QByteArrays, because "if it works, don't touch it!"
> 
> 
> Diffs
> -----
> 
>   kioslave/ftp/ftp.h 218b3578bd4649ab2ed332ec66a1ac0910d0e379 
>   kioslave/ftp/ftp.cpp 3de1aa36bf3664f669e4d2fbe63b571cca1c36f5 
> 
> Diff: http://git.reviewboard.kde.org/r/111246/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130626/9209e087/attachment.html>