Review Request 111236: move kcombobox and khistorycombobox to KCompletion framework.

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111236/#review35089
-----------------------------------------------------------

Ship it!


Good to go once 111232 is in.

- Kevin Ottens


On June 25, 2013, 11:43 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111236/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 11:43 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> move kcombobox and khistorycombobox to KCompletion framework.
> 
> This review depends on https://git.reviewboard.kde.org/r/111232/
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 3946ebf 
>   kdeui/tests/CMakeLists.txt 2dd4079 
>   kdeui/tests/kcombobox_unittest.cpp  
>   kdeui/tests/kcomboboxtest.h  
>   kdeui/tests/kcomboboxtest.cpp  
>   kdeui/widgets/kcombobox.h ccb019d 
>   kdeui/widgets/kcombobox.cpp c21c1de 
>   kdeui/widgets/khistorycombobox.h 42c9d45 
>   kdeui/widgets/khistorycombobox.cpp  
>   staging/kcompletion/src/CMakeLists.txt e502554 
>   staging/kcompletion/tests/CMakeLists.txt e8e39f3 
> 
> Diff: http://git.reviewboard.kde.org/r/111236/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130626/37e9b08f/attachment-0001.html>