Review Request 111232: move klineedit and kcompletionbox to KCompletion framework

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111232/#review35087
-----------------------------------------------------------



kdeui/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111232/#comment25673>

    Please don't move that class, try to see if you could port the relevant parts to QProxyStyle instead.



kdeui/widgets/klineedit.cpp
<http://git.reviewboard.kde.org/r/111232/#comment25674>

    You can't just remove that code, you have to provide something equivalent to the situation.
    
    Looking at KIconTheme::assignIconsToContextMenu implementation it is in fact rather dumb. So you can likely replace it by using a few setIcon(QIcon::fromTheme("edit-foo")) calls on the actions added to popup.



kdeui/widgets/klineedit_p.h
<http://git.reviewboard.kde.org/r/111232/#comment25675>

    spurious whitespaces


- Kevin Ottens


On June 25, 2013, 10:25 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111232/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 10:25 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> move klineedit and kcompletionbox to KCompletion framework
> 
> Notes:
> KIconTheme::assignIconsToContextMenu( KIconTheme::TextEditor, popup->actions () ) removed because there is task in Qt5 Epics (Add icons to QLineEdit context menu (via qstyle?)).
> 
> Can we cut dependency do KIconThemes too? 
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 3946ebf 
>   kdeui/tests/CMakeLists.txt 2dd4079 
>   kdeui/tests/klineedit_unittest.cpp  
>   kdeui/tests/klineedittest.h  
>   kdeui/tests/klineedittest.cpp  
>   kdeui/widgets/kcompletionbox.h 6e10dcf 
>   kdeui/widgets/kcompletionbox.cpp  
>   kdeui/widgets/kdeuiwidgetsproxystyle.cpp  
>   kdeui/widgets/kdeuiwidgetsproxystyle_p.h  
>   kdeui/widgets/klineedit.h 7ac22f6 
>   kdeui/widgets/klineedit.cpp 24920a8 
>   kdeui/widgets/klineedit_p.h 7c58f2d 
>   kfile/CMakeLists.txt bc48bf7 
>   kioslave/http/kcookiejar/CMakeLists.txt 2dae665 
>   knewstuff/knewstuff3/CMakeLists.txt 41ea203 
>   kross/ui/CMakeLists.txt 65e1abb 
>   kutils/CMakeLists.txt bfe8541 
>   security/crypto/CMakeLists.txt e890d33 
>   staging/kcompletion/autotests/CMakeLists.txt f497c9a 
>   staging/kcompletion/src/CMakeLists.txt e502554 
>   staging/kcompletion/src/config-kcompletion.h.cmake PRE-CREATION 
>   staging/kcompletion/tests/CMakeLists.txt e8e39f3 
>   staging/kde4attic/src/CMakeLists.txt 0cf1be7 
>   staging/kde4support/src/CMakeLists.txt 551181c 
>   staging/kemoticons/tests/CMakeLists.txt 3c59e7e 
> 
> Diff: http://git.reviewboard.kde.org/r/111232/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130626/a2e0021a/attachment.html>