Review Request 111184: Url drop functionality in KUrlRequester does not depend on KLineEdit (since we have to port it to QLineEdit)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111184/#review35051
-----------------------------------------------------------



KDE5PORTING.html
<http://git.reviewboard.kde.org/r/111184/#comment25658>

    I recommend adding an entry to KDE5PORTING.html only when removing a method/class altogether, or for bigger changes.
    For simple deprecated methods, it's enough (and easier to find) to have a @deprecated in the API docs for the method.
    
    "Use KUrlRequester instead" isn't exactly right, it looks rather different from a KLineEdit. One might not want that. See next comment for suggested doc.



kdeui/widgets/kcombobox.h
<http://git.reviewboard.kde.org/r/111184/#comment25657>

    the documentation for what to use instead should go here, in the method docu:
    
    @deprecated since 5.0, this functionality isn't available anymore, KUrlRequester was the only user, and uses an event filter now.



kio/kfile/kurlrequester.cpp
<http://git.reviewboard.kde.org/r/111184/#comment25661>

    Why this TODO? AFAICS kde4 didn't do that.



kio/kfile/kurlrequester.cpp
<http://git.reviewboard.kde.org/r/111184/#comment25668>

    I think it would be clearer to swap the nested ifs.
    
    First check the event type, then check the object. Simpler than object/event-type/object again depending on the event type...


- David Faure


On June 25, 2013, 10:46 a.m., Albert Vaca Cintora wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111184/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 10:46 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> KLineEdit and KComboBox had the property enableUrlDrops that was added to use it in KUrlRequester. Since KUrlRequester is part of KIO, it can not use Kde4Support and should be ported to use QLineEdit and QComboBox. As I said on my email to the frameworks list, it was easier to implement this directly in KUrlRequester than patching Qt, even though it was originally planned as a Qt task. It was my intention to also remove that property from KLineEdit and KComboBox, but finally I didn't include it in the patch (see Ervin's comment in the mailing list).
> 
> In the patch I have also added a TODO because I think it would be good to detect any url without needing the mimetype to be set, but I have not done it yet because it should be discussed first.
> 
> (Reviewed by aacid and apol)
> 
> 
> Diffs
> -----
> 
>   KDE5PORTING.html ba67bdc 
>   kdeui/widgets/kcombobox.h ccb019d 
>   kdeui/widgets/klineedit.h 7ac22f6 
>   kio/kfile/kurlrequester.cpp fa6b234 
> 
> Diff: http://git.reviewboard.kde.org/r/111184/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Albert Vaca Cintora
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130625/9c3b48cf/attachment-0001.html>