Review Request 111170: Move KTip to KWidgets

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111170/#review34976
-----------------------------------------------------------


This patch is mostly correct. The KConfig dependency should stay though.


staging/kwidgets/src/dialogs/ktip.h
<http://git.reviewboard.kde.org/r/111170/#comment25606>

    Wrong whitespace change.



staging/kwidgets/src/dialogs/ktip.cpp
<http://git.reviewboard.kde.org/r/111170/#comment25601>

    It should keep using KConfig. That's in fact why it's going in KWidgets and not KWidgetsAddons.



staging/kwidgets/src/dialogs/ktip.cpp
<http://git.reviewboard.kde.org/r/111170/#comment25602>

    Please revert that part of the patch.



staging/kwidgets/src/dialogs/ktip.cpp
<http://git.reviewboard.kde.org/r/111170/#comment25603>

    ditto.



staging/kwidgets/src/dialogs/ktip.cpp
<http://git.reviewboard.kde.org/r/111170/#comment25605>

    ditto.



staging/kwidgets/src/dialogs/ktip.cpp
<http://git.reviewboard.kde.org/r/111170/#comment25604>

    ditto.


- Kevin Ottens


On June 22, 2013, 9:57 a.m., Miquel Canes Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111170/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 9:57 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KTip to KWidgets
> * Use QSettings instead of KConfig.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 3946ebf 
>   staging/kwidgets/src/CMakeLists.txt 03a7d7a 
>   staging/kwidgets/src/dialogs/ktip.h 32c0474 
>   staging/kwidgets/src/dialogs/ktip.cpp 011e3b3 
> 
> Diff: http://git.reviewboard.kde.org/r/111170/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miquel Canes Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130624/781d8062/attachment.html>