Review Request 111191: Move KTextEdit to KTextWidgets

[Andrea Scarpino]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111191/
-----------------------------------------------------------

(Updated June 24, 2013, 10:45 a.m.)


Review request for KDE Frameworks.


Changes
-------

Do not use KGlobalSettings.

See http://lists.kde.org/?l=kde-frameworks-devel&m=137153612116214&w=2


Description
-------

Move KFind, KFindDialog, KReplace, KReplaceDialog, KTextEdit to KTextWidgets.

Notes:
* the dependency on kglobalsettings.h has been commented, otherwise a cycle-dependency is created here (KHelpMenu from XmlGui needs KTextEdit through KBugReport). What to do?
* the usage of KHistoryComboBox has been commented. Can be commented out when KHistoryComboBox is moved to staging.


Needs https://git.reviewboard.kde.org/r/111183/.


Diffs (updated)
-----

  kdeui/CMakeLists.txt 3946ebf 
  kdeui/findreplace/kfind.h cf65e39 
  kdeui/findreplace/kfind.cpp 02e5236 
  kdeui/findreplace/kfind_p.h 53b9870 
  kdeui/findreplace/kfinddialog.h 39de50c 
  kdeui/findreplace/kfinddialog.cpp c760e89 
  kdeui/findreplace/kfinddialog_p.h 019231f 
  kdeui/findreplace/kreplace.h a4e2c75 
  kdeui/findreplace/kreplace.cpp b8d509e 
  kdeui/findreplace/kreplacedialog.h 2416db1 
  kdeui/findreplace/kreplacedialog.cpp 0af24ec 
  kdeui/tests/CMakeLists.txt 2dd4079 
  kdeui/tests/kfindtest.h 648ee8a 
  kdeui/tests/kfindtest.cpp 369e6eb 
  kdeui/tests/kreplacetest.h 72674eb 
  kdeui/tests/kreplacetest.cpp 83e00a0 
  kdeui/tests/ktextedit_unittest.cpp 9d77574 
  kdeui/tests/ktextedittest.cpp 0509627 
  kdeui/widgets/ktextedit.h 0a0bbf6 
  kdeui/widgets/ktextedit.cpp 4605bfd 
  staging/CMakeLists.txt c7d0ede 
  staging/ktextwidgets/CMakeLists.txt PRE-CREATION 
  staging/ktextwidgets/autotests/CMakeLists.txt PRE-CREATION 
  staging/ktextwidgets/autotests/kfindtest.h PRE-CREATION 
  staging/ktextwidgets/autotests/kfindtest.cpp PRE-CREATION 
  staging/ktextwidgets/autotests/kreplacetest.h PRE-CREATION 
  staging/ktextwidgets/autotests/kreplacetest.cpp PRE-CREATION 
  staging/ktextwidgets/autotests/ktextedit_unittest.cpp PRE-CREATION 
  staging/ktextwidgets/ktextwidgetsConfig.cmake.in PRE-CREATION 
  staging/ktextwidgets/src/CMakeLists.txt PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kfind.h PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kfind.cpp PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kfind_p.h PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kfinddialog.h PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kfinddialog.cpp PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kfinddialog_p.h PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kreplace.h PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kreplace.cpp PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kreplacedialog.h PRE-CREATION 
  staging/ktextwidgets/src/findreplace/kreplacedialog.cpp PRE-CREATION 
  staging/ktextwidgets/src/widgets/ktextedit.h PRE-CREATION 
  staging/ktextwidgets/src/widgets/ktextedit.cpp PRE-CREATION 
  staging/ktextwidgets/tests/CMakeLists.txt PRE-CREATION 
  staging/ktextwidgets/tests/ktextedittest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111191/diff/


Testing
-------

Builds and tests passed. kreplacetest segfaults.


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130624/69ec0db5/attachment.html>