Review Request 111183: Move KLanguageButton to KWidgets

Andrea Scarpino scarpino at kde.org
Sun Jun 23 08:39:10 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111183/
-----------------------------------------------------------

(Updated June 23, 2013, 10:39 a.m.)


Review request for KDE Frameworks and Kevin Ottens.


Description
-------

The KLocate code is commented. I don't know if this is OK, or if I've to port it to QLocale first and then it can be moved to kwidgets.

This patch must be applied with the others 2 that I'm going to push later.
KHelpMenu uses KLanguageButton through KSwitchLanguageDialogPrivate.


Diffs
-----

  kdeui/CMakeLists.txt 3946ebf 
  kdeui/widgets/klanguagebutton.h feb2b5b 
  kdeui/widgets/klanguagebutton.cpp c5d8e4b 
  staging/kwidgets/src/CMakeLists.txt 03a7d7a 
  staging/kwidgets/src/widgets/klanguagebutton.h PRE-CREATION 
  staging/kwidgets/src/widgets/klanguagebutton.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111183/diff/


Testing
-------

Builds.


Thanks,

Andrea Scarpino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130623/80858e16/attachment.html>


More information about the Kde-frameworks-devel mailing list