Review Request 111103: KPage* belongs to KWidgetsAddons

Aleix Pol Gonzalez aleixpol at kde.org
Tue Jun 18 17:32:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111103/
-----------------------------------------------------------

Review request for KDE Frameworks.


Description
-------

When I moved KPage*, I moved it to KWidgets because I thought we needed the KGlobalSettings dependency, but then we did some magic so that it wasn't needed.

This patch moves it where it belongs.


Diffs
-----

  staging/kwidgets/src/CMakeLists.txt c019756 
  staging/kwidgets/src/paged/kpagedialog.h 382e70d 
  staging/kwidgets/src/paged/kpagedialog.cpp 542d6a2 
  staging/kwidgets/src/paged/kpagedialog_p.h 7eff46b 
  staging/kwidgets/src/paged/kpagemodel.h 6b10b78 
  staging/kwidgets/src/paged/kpagemodel.cpp 5e5cfa7 
  staging/kwidgets/src/paged/kpagemodel_p.h 6466f64 
  staging/kwidgets/src/paged/kpageview.h db624db 
  staging/kwidgets/src/paged/kpageview.cpp d250f32 
  staging/kwidgets/src/paged/kpageview_p.h 1058579 
  staging/kwidgets/src/paged/kpageview_p.cpp 180d3bc 
  staging/kwidgets/src/paged/kpagewidget.h a782468 
  staging/kwidgets/src/paged/kpagewidget.cpp e81ab57 
  staging/kwidgets/src/paged/kpagewidget_p.h 6eeaeccb 
  staging/kwidgets/src/paged/kpagewidgetmodel.h a53de9a 
  staging/kwidgets/src/paged/kpagewidgetmodel.cpp 0c38059 
  staging/kwidgets/src/paged/kpagewidgetmodel_p.h 8ab48e6 
  staging/kwidgets/tests/CMakeLists.txt 564d653 
  staging/kwidgets/tests/kpagedialogtest.h a5e9be5 
  staging/kwidgets/tests/kpagedialogtest.cpp b0e8efd 
  staging/kwidgets/tests/kpagewidgettest.h 206255b 
  staging/kwidgets/tests/kpagewidgettest.cpp a767401 
  tier1/kwidgetsaddons/src/CMakeLists.txt 7a58c0e 
  tier1/kwidgetsaddons/src/kpagedialog.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagedialog.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagedialog_p.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagemodel.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagemodel.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagemodel_p.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpageview.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpageview.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpageview_p.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpageview_p.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagewidget.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagewidget.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagewidget_p.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagewidgetmodel.h PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagewidgetmodel.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/kpagewidgetmodel_p.h PRE-CREATION 
  tier1/kwidgetsaddons/tests/CMakeLists.txt 53c21fc 
  tier1/kwidgetsaddons/tests/kpagedialogtest.h PRE-CREATION 
  tier1/kwidgetsaddons/tests/kpagedialogtest.cpp PRE-CREATION 
  tier1/kwidgetsaddons/tests/kpagewidgettest.h PRE-CREATION 
  tier1/kwidgetsaddons/tests/kpagewidgettest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111103/diff/


Testing
-------

builds


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130618/2d7c5994/attachment.html>


More information about the Kde-frameworks-devel mailing list