Review Request 111086: Move KXErrorHandler

[Kevin Ottens]

> On June 18, 2013, 1:48 p.m., Kevin Ottens wrote:
> > Ship It!

Hold on... Per Fredrik Höglund email which I totally overlooked until now, we're clearly doing that one wrong.
Please rework this patch so that kwindowsystem is untouched but the kdeui copy of kxerrorhandler goes in kde4support instead.

Sorry for the troubles, thanks in advance.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111086/#review34575
-----------------------------------------------------------


On June 18, 2013, 10:51 a.m., Benjamin Port wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111086/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 10:51 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Finish to moving KXErrorHandler
> 
> Export and rename kxerrorhandler_p.h
> Move kexerrorhandler test
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt c05adbd 
>   kdeui/tests/CMakeLists.txt dfe6292 
>   kdeui/tests/kxerrorhandlertest.cpp 8b624f2 
>   kdeui/util/kxerrorhandler.h be5cb76 
>   kdeui/util/kxerrorhandler.cpp 48d8abe 
>   tier1/kwindowsystem/CMakeLists.txt 3032ac7 
>   tier1/kwindowsystem/src/CMakeLists.txt b191830 
>   tier1/kwindowsystem/src/kwindowinfo_x11.cpp f382e9c 
>   tier1/kwindowsystem/src/kwindowsystem_x11.cpp cc2c5a0 
>   tier1/kwindowsystem/src/kxerrorhandler.h PRE-CREATION 
>   tier1/kwindowsystem/src/kxerrorhandler.cpp 67062de 
>   tier1/kwindowsystem/src/kxerrorhandler_p.h 53237a3 
>   tier1/kwindowsystem/src/kxutils.cpp 33bd678 
>   tier1/kwindowsystem/tests/CMakeLists.txt PRE-CREATION 
>   tier1/kwindowsystem/tests/kxerrorhandlertest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111086/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Port
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130618/350c2e6e/attachment.html>