Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110997/
-----------------------------------------------------------

(Updated June 14, 2013, 10:27 a.m.)


Review request for KDE Frameworks.


Changes
-------

Updated the patch with Kevin's suggestions.

Also generated the patch with "git diff --find-copies-harder". It reports copies.


Description
-------

Moved KPage*

Also ported the KPageListViewDelegate from using KIconLoader to get the icons size to QStyle. This makes it not possible to react to changes in the icon themes which shouldn't happen that often, and cuts a dependency instead.


Diffs (updated)
-----

  kdeui/CMakeLists.txt 46196b4 
  kdeui/dialogs/kassistantdialog.h 373e6cf 
  kdeui/dialogs/kconfigdialog.h ea342ac 
  kdeui/paged/kpagedialog.h 77a58d0 
  kdeui/paged/kpagedialog.cpp  
  kdeui/paged/kpagedialog_p.h 3893ba9 
  kdeui/paged/kpagemodel.h 6645c4e 
  kdeui/paged/kpagemodel.cpp  
  kdeui/paged/kpagemodel_p.h  
  kdeui/paged/kpageview.h 2d9fbe1 
  kdeui/paged/kpageview.cpp 6648e34 
  kdeui/paged/kpageview_p.h 6404cd6 
  kdeui/paged/kpageview_p.cpp 42bdfe3 
  kdeui/paged/kpagewidget.h 6cebef7 
  kdeui/paged/kpagewidget.cpp 7bbfeb2 
  kdeui/paged/kpagewidget_p.h  
  kdeui/paged/kpagewidgetmodel.h 0769a48 
  kdeui/paged/kpagewidgetmodel.cpp c5f6e41 
  kdeui/paged/kpagewidgetmodel_p.h 40c5fac 
  kdeui/tests/CMakeLists.txt 8746397 
  kdeui/tests/kpagedialogtest.h  
  kdeui/tests/kpagedialogtest.cpp  
  kdeui/tests/kpagewidgettest.h  
  kdeui/tests/kpagewidgettest.cpp  
  kio/CMakeLists.txt 6af7b6d 
  kutils/CMakeLists.txt 0276030 
  staging/kwidgets/src/CMakeLists.txt 03a7d7a 
  staging/kwidgets/tests/CMakeLists.txt f173b80 

Diff: http://git.reviewboard.kde.org/r/110997/diff/


Testing
-------

Everything builds, the test seems good.


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130614/4e628a96/attachment.html>