Review Request 110997: Move KPageWidgets and KPageDialog to KWidgets

[Aleix Pol Gonzalez]

> On June 13, 2013, 8:49 p.m., Christoph Feck wrote:
> > Using the reviewboard diff viewer, I can only see that you moved files, but it is impossible to see if there are any changes to them. Is there a way to view those changes, if any?

You can apply the files locally and use git. There you can get the changes, it's the only way I can think... :/

It would be a very good way to improve ReviewBoard indeed... :)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110997/#review34320
-----------------------------------------------------------


On June 13, 2013, 2:57 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110997/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 2:57 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Moved KPage*
> 
> Also ported the KPageListViewDelegate from using KIconLoader to get the icons size to QStyle. This makes it not possible to react to changes in the icon themes which shouldn't happen that often, and cuts a dependency instead.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 46196b4 
>   kdeui/dialogs/kassistantdialog.h 373e6cf 
>   kdeui/dialogs/kconfigdialog.h ea342ac 
>   kdeui/paged/kpagedialog.h 77a58d0 
>   kdeui/paged/kpagedialog.cpp 542d6a2 
>   kdeui/paged/kpagedialog_p.h 3893ba9 
>   kdeui/paged/kpagemodel.h 6645c4e 
>   kdeui/paged/kpagemodel.cpp 5e5cfa7 
>   kdeui/paged/kpagemodel_p.h 6466f64 
>   kdeui/paged/kpageview.h 2d9fbe1 
>   kdeui/paged/kpageview.cpp 6648e34 
>   kdeui/paged/kpageview_p.h 6404cd6 
>   kdeui/paged/kpageview_p.cpp 42bdfe3 
>   kdeui/paged/kpagewidget.h 6cebef7 
>   kdeui/paged/kpagewidget.cpp 7bbfeb2 
>   kdeui/paged/kpagewidget_p.h 6eeaeccb 
>   kdeui/paged/kpagewidgetmodel.h 0769a48 
>   kdeui/paged/kpagewidgetmodel.cpp c5f6e41 
>   kdeui/paged/kpagewidgetmodel_p.h 40c5fac 
>   kdeui/tests/CMakeLists.txt 8746397 
>   kdeui/tests/kpagedialogtest.h a5e9be5 
>   kdeui/tests/kpagedialogtest.cpp b0e8efd 
>   kdeui/tests/kpagewidgettest.h 206255b 
>   kdeui/tests/kpagewidgettest.cpp a767401 
>   kio/CMakeLists.txt 6af7b6d 
>   kutils/CMakeLists.txt 0276030 
>   staging/kwidgets/src/CMakeLists.txt 03a7d7a 
>   staging/kwidgets/src/paged/kpagedialog.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpagedialog.cpp PRE-CREATION 
>   staging/kwidgets/src/paged/kpagedialog_p.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpagemodel.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpagemodel.cpp PRE-CREATION 
>   staging/kwidgets/src/paged/kpagemodel_p.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpageview.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpageview.cpp PRE-CREATION 
>   staging/kwidgets/src/paged/kpageview_p.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpageview_p.cpp PRE-CREATION 
>   staging/kwidgets/src/paged/kpagewidget.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpagewidget.cpp PRE-CREATION 
>   staging/kwidgets/src/paged/kpagewidget_p.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpagewidgetmodel.h PRE-CREATION 
>   staging/kwidgets/src/paged/kpagewidgetmodel.cpp PRE-CREATION 
>   staging/kwidgets/src/paged/kpagewidgetmodel_p.h PRE-CREATION 
>   staging/kwidgets/tests/CMakeLists.txt f173b80 
>   staging/kwidgets/tests/kpagedialogtest.h PRE-CREATION 
>   staging/kwidgets/tests/kpagedialogtest.cpp PRE-CREATION 
>   staging/kwidgets/tests/kpagewidgettest.h PRE-CREATION 
>   staging/kwidgets/tests/kpagewidgettest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110997/diff/
> 
> 
> Testing
> -------
> 
> Everything builds, the test seems good.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130613/f80cb5e5/attachment.html>