Review Request 110988: Port kio-file to QFile

[David Faure]

> On June 13, 2013, 11:06 a.m., David Faure wrote:
> > kioslave/file/file.cpp, line 453
> > <http://git.reviewboard.kde.org/r/110988/diff/1/?file=149805#file149805line453>
> >
> >     Bug in the original code? Should be ..._FOR_WRITING if mode & QIODevice::WriteOnly?
> 
> Martin Klapetek wrote:
>     Would 
>     
>     if (mode & QIODevice::ReadOnly) {
>         error(KIO::ERR_CANNOT_OPEN_FOR_READING, openPath);
>     } else {
>         error(KIO::ERR_CANNOT_OPEN_FOR_WRITING, openPath);
>     }
>     
>     work? As the rest of the modes (WriteOnly, ReadWrite, Append, Truncate) assumes writing

Yep, looks good.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110988/#review34280
-----------------------------------------------------------


On June 13, 2013, 10:40 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110988/
> -----------------------------------------------------------
> 
> (Updated June 13, 2013, 10:40 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Ports away kioslave/file from unix/kde specific calls to QFile calls
> 
> 
> Diffs
> -----
> 
>   kioslave/file/file.h 93aeef4 
>   kioslave/file/file.cpp d57517b 
>   kioslave/file/file_unix.cpp 8b92e06 
> 
> Diff: http://git.reviewboard.kde.org/r/110988/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130613/4a10af57/attachment-0001.html>