Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

[David Faure]

> On June 12, 2013, 6:51 a.m., Kevin Ottens wrote:
> > khtml/misc/loader.h, line 422
> > <http://git.reviewboard.kde.org/r/110876/diff/2/?file=149646#file149646line422>
> >
> >     qint64 instead of int? probably better since that's what addSecs uses.
> 
> David Gil Oliva wrote:
>     Ok to change it, but the docs say addSecs uses int: QDateTime QDateTime::addSecs ( int s ) const
>     
>     On the other hand, QDateTime QDateTime::addMSecs ( qint64 msecs ) const
>     
>     Could you please confirm which one to use? :-)

Please look at Qt 5 docs, not at Qt 4 docs.

addSecs was changed from int to qint64.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110876/#review34204
-----------------------------------------------------------


On June 11, 2013, 10:10 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110876/
> -----------------------------------------------------------
> 
> (Updated June 11, 2013, 10:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_part.cpp 7027ceca7d05738e1fe0f808e1c808ddfe8e8df3 
>   khtml/misc/loader.h 5e9db0f8baef69c7bb146e4bd6c8cefcdbfe09c2 
>   khtml/misc/loader.cpp c8812755b99f841f6e7b90da8e154810c1f7c23f 
>   khtml/xml/dom_docimpl.cpp 15f491857ebd17ef21a6df8e187ed16052974cca 
> 
> Diff: http://git.reviewboard.kde.org/r/110876/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130613/659e064d/attachment.html>