Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)
David Faure
faure at kde.org
Tue Jun 11 10:02:00 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110945/#review34135
-----------------------------------------------------------
kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/110945/#comment25056>
Changing the serialization format will break the kio_http cache between 4.x and 5.x.
This isn't a problem in itself, unless we end up reading a 4.x with 5.x code or the other way around.
Fortunately, the cache moved from ~/.kde/cache-$HOSTNAME to ~/.cache, so this won't actually be a problem.
So, OK.
- David Faure
On June 10, 2013, 9:50 p.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110945/
> -----------------------------------------------------------
>
> (Updated June 10, 2013, 9:50 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Port time_t to QDateTime in HTTP (KIOSLAVE)
>
> --Fix some warnings about parentheses in conditionals.
> --Delete some includes that apparently weren't used.
>
> TODO:
> --Port QRegExp to QRegularExpression
> --Port QLatin1String to QStringLiteral where needed
>
>
> Diffs
> -----
>
> kioslave/http/http.h b16254ec815106c63f4b73ea4a13a9bc4a393a71
> kioslave/http/http.cpp c7b7c03991d26ade0b85615a3a798b479a5bbc1f
>
> Diff: http://git.reviewboard.kde.org/r/110945/diff/
>
>
> Testing
> -------
>
> It builds.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130611/4a635955/attachment.html>
More information about the Kde-frameworks-devel
mailing list