Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

[Kevin Ottens]

> On June 11, 2013, 9:15 a.m., Kevin Ottens wrote:
> > Ship It!

Ooops... I validated by mistake. :-)

This diff is fine, but it looks incomplete, I don't see the CMakeLists.txt changes or the kthml and kdeui changes you referred to in your comment.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110907/#review34118
-----------------------------------------------------------


On June 9, 2013, 1:54 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110907/
> -----------------------------------------------------------
> 
> (Updated June 9, 2013, 1:54 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> Move kdeprintdialog.h and kcups* to kde4support
> Fix compilation 
> Mark as deprecated
> Things I am unsure of: the change in khtml/khtmlview.cpp and in kdeui/dialogs/kshortcutseditor.cpp, some CMakeLists moves as well are to be checked.
> 
> 
> Diffs
> -----
> 
>   staging/kde4support/src/kdeui/kdeprintdialog.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110907/diff/
> 
> 
> Testing
> -------
> 
> Build
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130611/8c9075c1/attachment.html>