Review Request 110945: Port time_t to QDateTime in HTTP (KIOSLAVE)

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110945/#review34110
-----------------------------------------------------------



kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/110945/#comment25050>

    If the goal is to get rid of time_t, probably removing the calls to toTime_t() here and changing the return value of parseDateTime to QDateTime would be a good idea.



kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/110945/#comment25051>

    Likewise formatHttpDate could be modified to use QDateTime as input.



kioslave/http/http.cpp
<http://git.reviewboard.kde.org/r/110945/#comment25054>

    It's a QDataStream so we could use a QDateTime in there (would require adjusting deserialize too... means we can get rid of readTime() completely).
    
    David, any opinion for such an adjustment?


- Kevin Ottens


On June 10, 2013, 9:50 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110945/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 9:50 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in HTTP (KIOSLAVE)
> 
> --Fix some warnings about parentheses in conditionals.
> --Delete some includes that apparently weren't used.
> 
> TODO:
> --Port QRegExp to QRegularExpression
> --Port QLatin1String to QStringLiteral where needed
> 
> 
> Diffs
> -----
> 
>   kioslave/http/http.h b16254ec815106c63f4b73ea4a13a9bc4a393a71 
>   kioslave/http/http.cpp c7b7c03991d26ade0b85615a3a798b479a5bbc1f 
> 
> Diff: http://git.reviewboard.kde.org/r/110945/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130611/efd1aefd/attachment.html>