Review Request 110876: Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)

[David Gil Oliva]

> On June 8, 2013, 11:32 a.m., David Faure wrote:
> > khtml/xml/dom_docimpl.cpp, line 2007
> > <http://git.reviewboard.kde.org/r/110876/diff/1/?file=149046#file149046line2007>
> >
> >     This is the "relative" code path. Did you forget to add m_creationDate, like setExpireDate(date, true) used to do?

The problem I have refers to how do I add two QDateTimes, which are two points in time. I don't even understand how does it make sense to add two time_t that refer to two moments in time (m_creationDate and _expireDate), so when _expireDate is relative, it has to mean actually a lapse of time... It is this ambiguity of time_t that drives me crazy! 8-O  ?:-/

An idea would be to overload:

void DocLoader::setExpireDate(int seconds);

(here those seconds would be added to m_creationDate)

or to make another method:

void DocLoader::setRelativeExpireDate(int seconds);


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110876/#review33937
-----------------------------------------------------------


On June 7, 2013, 10:35 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110876/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 10:35 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in Loader, KHTMLPart and DocumentImpl (KHTML)
> 
> 
> Diffs
> -----
> 
>   khtml/khtml_part.cpp a97ca0d8179a438a0ceb713100b5c335995ae9f4 
>   khtml/misc/loader.h 5e9db0f8baef69c7bb146e4bd6c8cefcdbfe09c2 
>   khtml/misc/loader.cpp c8812755b99f841f6e7b90da8e154810c1f7c23f 
>   khtml/xml/dom_docimpl.cpp 15f491857ebd17ef21a6df8e187ed16052974cca 
> 
> Diff: http://git.reviewboard.kde.org/r/110876/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130609/6a01833e/attachment.html>