Review Request 110907: Move kdeprintdialog.h and kcups* to kde4support

Anne-Marie Mahfouf annma at kde.org
Sun Jun 9 09:47:24 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110907/
-----------------------------------------------------------

Review request for KDE Frameworks and David Faure.


Description
-------

Move kdeprintdialog.h and kcups* to kde4support
Fix compilation 
Mark as deprecated
Things I am unsure of: the change in khtml/khtmlview.cpp and in kdeui/dialogs/kshortcutseditor.cpp, some CMakeLists moves as well are to be checked.


Diffs
-----

  kdeui/CMakeLists.txt 3302cc0 
  kdeui/dialogs/kcupsoptionsjobwidget.ui 182b23e 
  kdeui/dialogs/kcupsoptionsjobwidget_p.h 9302f20 
  kdeui/dialogs/kcupsoptionsjobwidget_p.cpp 66b20b3 
  kdeui/dialogs/kcupsoptionspageswidget.ui d2494c7 
  kdeui/dialogs/kcupsoptionspageswidget_p.h ede67e6 
  kdeui/dialogs/kcupsoptionspageswidget_p.cpp f99fc8f 
  kdeui/dialogs/kcupsoptionssettingswidget_p.h 8d26e33 
  kdeui/dialogs/kcupsoptionssettingswidget_p.cpp 7b58a37 
  kdeui/dialogs/kcupsoptionswidget_p.h fc5c9e1 
  kdeui/dialogs/kcupsoptionswidget_p.cpp 363c0b8 
  kdeui/dialogs/kdeprint_nup1.png 9f13429be1d946ae682bd7b8b4e22850c3337b10 
  kdeui/dialogs/kdeprint_nup2.png 7289a7e68ea19dc0e767f3bfe3c4c316b03b143e 
  kdeui/dialogs/kdeprint_nup4.png b03a539fc4eb586b836171745353cb5fc8963478 
  kdeui/dialogs/kdeprint_nupother.png 5a7c385866b335d4751a8adbec295dc096b53c30 
  kdeui/dialogs/kdeprintdialog.h ce39771 
  kdeui/dialogs/kdeprintdialog.cpp 393aa9f 
  kdeui/dialogs/kshortcutseditor.cpp 5f84cac 
  khtml/khtmlview.cpp 69b527a 
  staging/kde4support/src/CMakeLists.txt 1f6edde 
  staging/kde4support/src/kdeui/kcupsoptionsjobwidget.ui PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionsjobwidget_p.h PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionsjobwidget_p.cpp PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionspageswidget.ui PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionspageswidget_p.h PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionspageswidget_p.cpp PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionssettingswidget_p.h PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionssettingswidget_p.cpp PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionswidget_p.h PRE-CREATION 
  staging/kde4support/src/kdeui/kcupsoptionswidget_p.cpp PRE-CREATION 
  staging/kde4support/src/kdeui/kdeprint_nup1.png PRE-CREATION 
  staging/kde4support/src/kdeui/kdeprint_nup2.png PRE-CREATION 
  staging/kde4support/src/kdeui/kdeprint_nup4.png PRE-CREATION 
  staging/kde4support/src/kdeui/kdeprint_nupother.png PRE-CREATION 
  staging/kde4support/src/kdeui/kdeprintdialog.h PRE-CREATION 
  staging/kde4support/src/kdeui/kdeprintdialog.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/110907/diff/


Testing
-------

Build


Thanks,

Anne-Marie Mahfouf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130609/978be0e2/attachment.html>


More information about the Kde-frameworks-devel mailing list