Review Request 110418: Move KNumInput to KDE4Support

[Anne-Marie Mahfouf]

> On June 3, 2013, 10:18 a.m., David Faure wrote:
> > kdeui/dialogs/kconfigdialogmanager.cpp, line 146
> > <http://git.reviewboard.kde.org/r/110418/diff/2/?file=146814#file146814line146>
> >
> >     OK, first step is a unittest. Can you confirm that your commit breaks this test?
> >     http://www.davidfaure.fr/2013/kconfigdialog_unittest_numinput.diff
> >     (it passes for me, with unmodified frameworks branch)
> >     
> >     Oh, and you didn't see it, but the class documentation for KConfigDialogManager actually explains how to register a custom class from the outside.
> >     
> >     So something like this should fix it, please test:
> >     
> >     KConfigDialogManager::changedMap()->insert("KIntNumInput", SIGNAL(valueChanged(int)));
> >     
> >

The test passes but outputs "QDEBUG : KConfigDialog_UnitTest::test() Don't know how to monitor widget ' KIntNumInput ' for changes!
"
while when KConfigDialogManager::changedMap()->insert("KIntNumInput", SIGNAL(valueChanged(int))); is added in KNumInput constructor the widget is monitored (and the test still passes)


- Anne-Marie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110418/#review33632
-----------------------------------------------------------


On May 28, 2013, 7:45 p.m., Anne-Marie Mahfouf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110418/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 7:45 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Move KNumInput to KDE4Support, use QSpinBox or QDoubleSpinBox instead.
> Test moved as well.
> 
> 
> Diffs
> -----
> 
>   kdeui/dialogs/kconfigdialogmanager.cpp 87c3e48 
>   kdeui/dialogs/kinputdialog.cpp 6cbd881 
>   kdeui/dialogs/kinputdialog_p.h dcdff3f 
>   kdeui/tests/krulertest.h fc677c6 
>   kdeui/tests/krulertest.cpp 9686421 
>   staging/kde4support/src/kdeui/kcolordialog.cpp 041c06a 
> 
> Diff: http://git.reviewboard.kde.org/r/110418/diff/
> 
> 
> Testing
> -------
> 
> Build tested
> 
> 
> Thanks,
> 
> Anne-Marie Mahfouf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130608/b9a9f5f9/attachment-0001.html>