Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

[David Gil Oliva]

> On June 7, 2013, 1:50 p.m., David Faure wrote:
> > kio/kio/slavebase.cpp, line 526
> > <http://git.reviewboard.kde.org/r/110836/diff/3/?file=148966#file148966line526>
> >
> >     Hum, I think you removed a bit too much code, the timeout handling is gone :-)
> >     
> >     Sorry if I said something unclear.
> >     Let me make that up by contributing the missing code, based on your previous iteration:
> >     
> >     else {
> >         if (d->lastTimeout.isValid())
> >             emitSignal = d->lastTimeout.msecsTo(now); // emit size 10 times a second
> >         else
> >             emitSignal = true;
> >     }

The fault is actually mine. I try hard to do my best, but sometimes I don't quite understand the code and I basically make the moves by intuition. So, thank you for the code!!


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110836/#review33901
-----------------------------------------------------------


On June 7, 2013, 1 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110836/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 1 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in SlaveBase (KIO)
> 
> 
> Diffs
> -----
> 
>   kio/kio/slavebase.cpp e5333cfff24d0fdb3eb7f123413e8fb80e504d37 
> 
> Diff: http://git.reviewboard.kde.org/r/110836/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130607/9a034ffc/attachment.html>