Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110836/#review33898
-----------------------------------------------------------


Behavior seems correct now, just some suggestions for readability 


kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24957>

    Could be renamed to nextTimeout, right?



kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24956>

    Hmm, so basically emitSignal = true. The 2000 value means nothing. It's a local hack
    .
    You could get rid of the msecdiff variable, in fact.


Behavior

- David Faure


On June 7, 2013, 12:07 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110836/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 12:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in SlaveBase (KIO)
> 
> 
> Diffs
> -----
> 
>   kio/kio/slavebase.cpp e5333cfff24d0fdb3eb7f123413e8fb80e504d37 
> 
> Diff: http://git.reviewboard.kde.org/r/110836/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130607/ba898d77/attachment.html>