Review Request 110847: Move KPixmapRegionSelector* to KWidgetsAddons
David Faure
faure at kde.org
Thu Jun 6 10:53:15 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110847/#review33856
-----------------------------------------------------------
Ship it!
Looks fine, just a few comments about indentation since you said you touched that.
The .cpp also has non-indented blocks....
tier1/kwidgetsaddons/src/kpixmapregionselectordialog.h
<http://git.reviewboard.kde.org/r/110847/#comment24935>
Usually indented
tier1/kwidgetsaddons/src/kpixmapregionselectorwidget.h
<http://git.reviewboard.kde.org/r/110847/#comment24936>
One space missing
tier1/kwidgetsaddons/src/kpixmapregionselectorwidget.h
<http://git.reviewboard.kde.org/r/110847/#comment24937>
Remove trailing space (everywhere)
- David Faure
On June 6, 2013, 1:03 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110847/
> -----------------------------------------------------------
>
> (Updated June 6, 2013, 1:03 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Besides the move, I decided to do some changes in the indentation. It was especially messy (sometimes 2 spaces, sometimes 3).
> I hope it's ok.
>
>
> Diffs
> -----
>
> tier1/kwidgetsaddons/src/CMakeLists.txt 3666358
> tier1/kwidgetsaddons/src/kpixmapregionselectordialog.h PRE-CREATION
> tier1/kwidgetsaddons/src/kpixmapregionselectordialog.cpp PRE-CREATION
> tier1/kwidgetsaddons/src/kpixmapregionselectorwidget.h PRE-CREATION
> tier1/kwidgetsaddons/src/kpixmapregionselectorwidget.cpp PRE-CREATION
> tier1/kwidgetsaddons/tests/CMakeLists.txt 2bb9306
> tier1/kwidgetsaddons/tests/kpixmapregionselectordialogtest.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/110847/diff/
>
>
> Testing
> -------
>
> builds and the test seems to work
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130606/5ae6e8f3/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list