Review Request 110838: Moved KColorCombo to KWidgetsAddons
David Faure
faure at kde.org
Wed Jun 5 23:01:24 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110838/#review33838
-----------------------------------------------------------
Ship it!
Would be a good opportunity to fix some of the broken indentation, but other than that, looks fine.
tier1/kwidgetsaddons/tests/kcolorcombotest.cpp
<http://git.reviewboard.kde.org/r/110838/#comment24926>
So this is what life before qtestlib looked like... :-)
- David Faure
On June 5, 2013, 10:39 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110838/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 10:39 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Just moved it, no big changes needed, apparently.
>
>
> Diffs
> -----
>
> tier1/kwidgetsaddons/tests/kcolorcombotest.cpp PRE-CREATION
> tier1/kwidgetsaddons/tests/kcolorcombotest.h PRE-CREATION
> tier1/kwidgetsaddons/tests/CMakeLists.txt 85a8732
> tier1/kwidgetsaddons/src/kcolorcombo.cpp PRE-CREATION
> tier1/kwidgetsaddons/src/kcolorcombo.h PRE-CREATION
> tier1/kwidgetsaddons/src/CMakeLists.txt 1a2c3e7
>
> Diff: http://git.reviewboard.kde.org/r/110838/diff/
>
>
> Testing
> -------
>
> The test still runs, seems to work.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/d5dcd28a/attachment.html>
More information about the Kde-frameworks-devel
mailing list