Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)
David Gil Oliva
davidgiloliva at gmail.com
Wed Jun 5 22:35:27 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110836/#review33834
-----------------------------------------------------------
kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24921>
AFAIK, time_t can be either a given moment in time (say 2013-06-06, 00:00) or an elapsed time (say 136 seconds).
On the other hand, QDateTime can only be a given moment in time. That's why I try to transform the time_t of elapsed time to integers and work with seconds.
I'll try to stick with QDateTime and compute the timeouts using other means.
- David Gil Oliva
On June 5, 2013, 11:19 a.m., David Gil Oliva wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110836/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 11:19 a.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Description
> -------
>
> Port time_t to QDateTime in SlaveBase (KIO)
>
>
> Diffs
> -----
>
> kio/kio/slavebase.cpp e5333cfff24d0fdb3eb7f123413e8fb80e504d37
>
> Diff: http://git.reviewboard.kde.org/r/110836/diff/
>
>
> Testing
> -------
>
> It builds.
>
>
> Thanks,
>
> David Gil Oliva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/a6d85df8/attachment.html>
More information about the Kde-frameworks-devel
mailing list