Review Request 110840: Move KFontComboBox to KDE4Support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110840/#review33833
-----------------------------------------------------------



staging/kde4support/src/kdeui/fonthelpers.cpp
<http://git.reviewboard.kde.org/r/110840/#comment24918>

    LOL



staging/kde4support/src/kdeui/kfontcombobox.h
<http://git.reviewboard.kde.org/r/110840/#comment24919>

    @deprecated since 5.0, use Q.... instead
    
    (with precise porting instructions for setOnlyFixed and setFontList). Think of the poor souls will have to do the porting :)



staging/kde4support/src/kdeui/kfontcombobox.h
<http://git.reviewboard.kde.org/r/110840/#comment24920>

    KDE4SUPPORT_DEPRECATED_EXPORT, like all classes in kde4support.


- David Faure


On June 5, 2013, 6:32 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110840/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 6:32 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KFontComboBox to KDE4Support
> 
> Cleanup now redundant kdeui/fonts folder
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 6e7b7ee772e9758d12f88d85e58e85761ef2c18e 
>   kdeui/fonts/fonthelpers.cpp 090616571bebcdc76e751b027bccf007f73af0e2 
>   kdeui/fonts/fonthelpers_p.h 090b99d49f4cf3974c80262443f5b6bb5028ea8d 
>   kdeui/fonts/kfontcombobox.h 536acbe5ea0f023584e2e14752c8836072f14f5c 
>   kdeui/fonts/kfontcombobox.cpp 7097ec3b02957bbcfa5cb07370418471b6a9389e 
>   kdeui/fonts/sampleedit_p.h bfdb714d60b4e2289375173291f5fd239f66582e 
>   staging/kde4support/src/CMakeLists.txt 1f6eddec1736e3168a114bba17b02e5862a73d6d 
>   staging/kde4support/src/kdeui/fonthelpers.cpp PRE-CREATION 
>   staging/kde4support/src/kdeui/fonthelpers_p.h PRE-CREATION 
>   staging/kde4support/src/kdeui/kfontcombobox.h PRE-CREATION 
>   staging/kde4support/src/kdeui/kfontcombobox.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110840/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/cee61356/attachment.html>