Review Request 110836: Port time_t to QDateTime in SlaveBase (KIO)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110836/#review33827
-----------------------------------------------------------



kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24914>

    Please document the unit being used.



kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24915>

    Wouldn't it be better to use a QDateTime for "timeout", rather than convert everything to time_t (and get problems in 2038?).



kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24916>

    currentDateTime is always valid, I would think we can remove this if()?



kio/kio/slavebase.cpp
<http://git.reviewboard.kde.org/r/110836/#comment24917>

    1) a difference of milliseconds doesn't give a result in microseconds.
    
    2) this whole business about splitting up the usec from the sec is just an artefact of the timeval API. Surely we can simplify this code with the port to QDateTime?
    
    We want a time difference in msec, that sounds like a one-liner with QDateTime::msecsTo()


- David Faure


On June 5, 2013, 11:19 a.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110836/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in SlaveBase (KIO)
> 
> 
> Diffs
> -----
> 
>   kio/kio/slavebase.cpp e5333cfff24d0fdb3eb7f123413e8fb80e504d37 
> 
> Diff: http://git.reviewboard.kde.org/r/110836/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/4f10a4d1/attachment-0001.html>