Review Request 110837: Port away ItemViews from KLineEdit and i18n

David Faure faure at kde.org
Wed Jun 5 14:24:14 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110837/#review33808
-----------------------------------------------------------

Ship it!


- David Faure


On June 5, 2013, 11:42 a.m., Wojciech Kapuscinski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110837/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 11:42 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Kevin Ottens.
> 
> 
> Description
> -------
> 
> Port away ItemViews from KLineEdit and i18n. 
> 
> KListWidgetSearchLine lost trapReturnKey but according to lxr only one class use this feature. 
> 
> trapReturnKey can restore like in https://git.reviewboard.kde.org/r/110825/
>  
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/kcategorizedsortfilterproxymodel.cpp c433c3d 
>   kdeui/itemviews/kfilterproxysearchline.h a0cd7f3 
>   kdeui/itemviews/kfilterproxysearchline.cpp 11ddf81 
>   kdeui/itemviews/klistwidgetsearchline.h 9ab82e2 
>   kdeui/itemviews/klistwidgetsearchline.cpp 6d3a158 
>   kdeui/itemviews/ktreewidgetsearchline.h 65d2f9d 
>   kdeui/itemviews/ktreewidgetsearchline.cpp a6927f0 
>   kdeui/itemviews/kwidgetitemdelegatepool.cpp 0ea4f02 
> 
> Diff: http://git.reviewboard.kde.org/r/110837/diff/
> 
> 
> Testing
> -------
> 
> It builds, all tests passed
> 
> 
> Thanks,
> 
> Wojciech Kapuscinski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/6e2b4734/attachment.html>


More information about the Kde-frameworks-devel mailing list