Review Request 110833: Remove KIconLoader dependency to KWidgets

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110833/#review33807
-----------------------------------------------------------


Cool. Almost there :)


staging/kiconthemes/src/kiconloader.h
<http://git.reviewboard.kde.org/r/110833/#comment24907>

    trailing space, copy/pasted multiple times



staging/kwidgets/src/utils/kglobalsettings.h
<http://git.reviewboard.kde.org/r/110833/#comment24908>

    add KWIDGETS_DEPRECATED?



staging/kwidgets/src/utils/kglobalsettings.cpp
<http://git.reviewboard.kde.org/r/110833/#comment24909>

    This is quite slow, it initializes the full icon theme, looking at many files on disk.
    
    Make it a static method in KIconLoader instead, all it does it call something in the global object anyway (so no need for "this").


- David Faure


On June 5, 2013, 11:21 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110833/
> -----------------------------------------------------------
> 
> (Updated June 5, 2013, 11:21 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> As we discussed in the IRC meeting, I removed the KIconLoader dependency to KWidgets (so that we can make KWidgets depend on KIconLoader).
> 
> I'm unsure if it's the best approach, so I tried to do the simplest implementation I could. Don't hesitate to suggest changes.
> 
> 
> Diffs
> -----
> 
>   staging/kiconthemes/src/CMakeLists.txt 82828dc 
>   staging/kiconthemes/src/kiconloader.h e4423eb 
>   staging/kiconthemes/src/kiconloader.cpp 795ec93 
>   staging/kwidgets/src/utils/kglobalsettings.h 5fb1d9b 
>   staging/kwidgets/src/utils/kglobalsettings.cpp 53b648e 
> 
> Diff: http://git.reviewboard.kde.org/r/110833/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/624882df/attachment.html>