Review Request 110825: Move KEditListWidget to KWidgetAddons

Commit Hook null at kde.org
Wed Jun 5 11:02:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110825/#review33791
-----------------------------------------------------------


This review has been submitted with commit 1a90976e606a2653db20ac51c54aa58475ad9927 by Aleix Pol to branch frameworks.

- Commit Hook


On June 4, 2013, 2:54 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110825/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 2:54 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Moved KEditListWidget to KWidgetAddons.
> 
> I changed from KLineEdit to QLineEdit, which I think it's the one that we're supposed to have. Everything worked, but QLineEdit doesn't have setTrapReturnKey. I added code in the event filter to trap the lineedit's return key.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 6e7b7ee 
>   kdeui/tests/CMakeLists.txt 6fca0bb 
>   kdeui/tests/keditlistwidgettest.cpp ad1a97d 
>   kdeui/widgets/keditlistwidget.h dfc16da 
>   kdeui/widgets/keditlistwidget.cpp 075bac3 
>   kio/kfile/kurlrequester.h 0b07373 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 9802467 
>   tier1/kwidgetsaddons/src/keditlistwidget.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/keditlistwidget.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8 
>   tier1/kwidgetsaddons/tests/keditlistwidgettest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110825/diff/
> 
> 
> Testing
> -------
> 
> everything builds, the test seems to work
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130605/aa6ba154/attachment.html>


More information about the Kde-frameworks-devel mailing list