Review Request 110820: Move KActionSelector to KWidgetAddons

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110820/#review33767
-----------------------------------------------------------



tier1/kwidgetsaddons/src/kactionselector.h
<http://git.reviewboard.kde.org/r/110820/#comment24890>

    This comment should be removed, polish() isn't virtual anymore since Qt 4.0...
    
    I see that it's called by other means (selection changed), but maybe there's a latent qt4 porting bug here, if it should also be called from event() when type==QEvent::Polish... but thinking about it, the app will add its items after the constructor, which will change [current] selection, always, I presume. And if no items, then the initial disabling is still good.
    
    
    So, basically, if it works, remove comment, and ideally turn that slot into a Q_PRIVATE_SLOT like the others.



tier1/kwidgetsaddons/src/kactionselector.cpp
<http://git.reviewboard.kde.org/r/110820/#comment24889>

    wrong indentation


- David Faure


On June 3, 2013, 5:29 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110820/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 5:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Moved KActionSelector to KWidgetAddons
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 46e08df 
>   kdeui/tests/CMakeLists.txt 5c1f386 
>   kdeui/tests/kactionselectortest.cpp 60fedd3 
>   kdeui/widgets/kactionselector.h 67d7a7a 
>   kdeui/widgets/kactionselector.cpp 55cfe79 
>   tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
>   tier1/kwidgetsaddons/src/kactionselector.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/kactionselector.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4 
>   tier1/kwidgetsaddons/tests/kactionselectortest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110820/diff/
> 
> 
> Testing
> -------
> 
> Compiled, test seems to work fine.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130604/ceda33af/attachment.html>