Review Request 110826: Move KRatingPainter and KRatingWidget to KWidgetsAddons

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110826/#review33741
-----------------------------------------------------------



tier1/kwidgetsaddons/src/kratingpainter.h
<http://git.reviewboard.kde.org/r/110826/#comment24875>

    No it isn't. *4



tier1/kwidgetsaddons/src/kratingpainter.h
<http://git.reviewboard.kde.org/r/110826/#comment24874>

    This doesn't match the file name.



tier1/kwidgetsaddons/src/kratingwidget.h
<http://git.reviewboard.kde.org/r/110826/#comment24872>

    Needs changing
    



tier1/kwidgetsaddons/src/kratingwidget.h
<http://git.reviewboard.kde.org/r/110826/#comment24873>

    Needs changing


- David Edmundson


On June 4, 2013, 2:40 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110826/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 2:40 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Move KRatingPainter and KRatingWidget to KWidgetsAddons
> 
> I didn't find any major problem when doing the move.
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/src/kratingpainter.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/src/kratingpainter.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 9802467 
>   kdeui/widgets/kratingwidget.cpp 52b7819 
>   kdeui/widgets/kratingwidget.h e8f5f13 
>   kdeui/widgets/kratingpainter.cpp 62e1705 
>   kdeui/widgets/kratingpainter.h 804bf69 
>   kdeui/tests/kratingwidgettest.cpp ae9816b 
>   kdeui/CMakeLists.txt 6e7b7ee 
>   kdeui/tests/CMakeLists.txt 6fca0bb 
>   tier1/kwidgetsaddons/src/kratingwidget.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/kratingwidget.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8 
>   tier1/kwidgetsaddons/tests/kratingwidgettest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130604/3d05fe95/attachment.html>