Review Request 110825: Move KEditListWidget to KWidgetAddons

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110825/#review33740
-----------------------------------------------------------



tier1/kwidgetsaddons/src/keditlistwidget.cpp
<http://git.reviewboard.kde.org/r/110825/#comment24869>

    KComboBox is due to go to KCompletion
    
    I don't think you're allowed to use it.



tier1/kwidgetsaddons/src/keditlistwidget.cpp
<http://git.reviewboard.kde.org/r/110825/#comment24870>

    This isn't used.



tier1/kwidgetsaddons/tests/keditlistwidgettest.cpp
<http://git.reviewboard.kde.org/r/110825/#comment24871>

    If you know you are going to make a QString from the string QStringLiteral is preferred to QLatin1String. (new in Qt5)
    
    I'm trying to start documenting these things here: http://community.kde.org/Frameworks/GettingStarted#Strings. Please expand/add to it. 


- David Edmundson


On June 4, 2013, 2:17 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110825/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 2:17 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Moved KEditListWidget to KWidgetAddons.
> 
> I changed from KLineEdit to QLineEdit, which I think it's the one that we're supposed to have. Everything worked, but QLineEdit doesn't have setTrapReturnKey. I added code in the event filter to trap the lineedit's return key.
> 
> 
> Diffs
> -----
> 
>   tier1/kwidgetsaddons/src/keditlistwidget.cpp PRE-CREATION 
>   tier1/kwidgetsaddons/src/keditlistwidget.h PRE-CREATION 
>   tier1/kwidgetsaddons/src/CMakeLists.txt 9802467 
>   kio/kfile/kurlrequester.h 0b07373 
>   kdeui/widgets/keditlistwidget.cpp 075bac3 
>   kdeui/widgets/keditlistwidget.h dfc16da 
>   kdeui/tests/keditlistwidgettest.cpp ad1a97d 
>   kdeui/CMakeLists.txt 6e7b7ee 
>   kdeui/tests/CMakeLists.txt 6fca0bb 
>   tier1/kwidgetsaddons/tests/CMakeLists.txt bd00be8 
>   tier1/kwidgetsaddons/tests/keditlistwidgettest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/110825/diff/
> 
> 
> Testing
> -------
> 
> everything builds, the test seems to work
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130604/0cfbb59c/attachment-0001.html>