Review Request 110674: Moving KToolBarSpacerAction to KWidgetsAddons

Aleix Pol Gonzalez aleixpol at kde.org
Mon Jun 3 16:08:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110674/
-----------------------------------------------------------

(Updated June 3, 2013, 4:08 p.m.)


Review request for KDE Frameworks.


Changes
-------

Moves the class to KWidgetsAddons as discussed

Also remove the *width properties that nobody seemed to be using


Summary (updated)
-----------------

Moving KToolBarSpacerAction to KWidgetsAddons


Description
-------

Just moves the file, nobody seems to be using it in kdelibs anyway.


Diffs (updated)
-----

  tier1/kwidgetsaddons/src/ktoolbarspaceraction.cpp PRE-CREATION 
  tier1/kwidgetsaddons/src/ktoolbarspaceraction.h PRE-CREATION 
  tier1/kwidgetsaddons/src/CMakeLists.txt df22699 
  kdeui/actions/ktoolbarspaceraction.cpp db79af2 
  kdeui/CMakeLists.txt 46e08df 
  kdeui/actions/ktoolbarspaceraction.h 32e8fb2 

Diff: http://git.reviewboard.kde.org/r/110674/diff/


Testing
-------

Builds and installs fine.


File Attachments
----------------

::addSeparator()
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-nospaceraction.png
KToolBarSpacerAction
  http://git.reviewboard.kde.org/media/uploaded/files/2013/06/03/k3b-spaceraction.png


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130603/851c7216/attachment.html>


More information about the Kde-frameworks-devel mailing list