Review Request 110764: Port time_t to QDateTime in Slave (KIO)

David Faure faure at kde.org
Mon Jun 3 10:04:18 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110764/#review33629
-----------------------------------------------------------



kio/kio/slave.cpp
<http://git.reviewboard.kde.org/r/110764/#comment24831>

    So, if the slave is not idle, idleTime() says it has been idle for 43 years?
    
    The old implementation returned 0 instead, which makes more sense to me.


- David Faure


On June 1, 2013, 9:58 a.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110764/
> -----------------------------------------------------------
> 
> (Updated June 1, 2013, 9:58 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in Slave (KIO)
> 
> 
> Diffs
> -----
> 
>   kio/kio/slave.h 800a0e8d21b22dfff29c3e0f876e194e30dedef8 
>   kio/kio/slave.cpp 798c61914a3618487f8d75bb0d07647b41faa79f 
> 
> Diff: http://git.reviewboard.kde.org/r/110764/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130603/8e942c9b/attachment.html>


More information about the Kde-frameworks-devel mailing list