Review Request 110760: Port time_t to QDateTime in KLauncher

David Faure faure at kde.org
Mon Jun 3 10:00:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110760/#review33626
-----------------------------------------------------------

Ship it!


Looks good, just one detail to fix, then commit.


kinit/klauncher.h
<http://git.reviewboard.kde.org/r/110760/#comment24830>

    this should be "const QDateTime &now"


- David Faure


On May 31, 2013, 10:48 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110760/
> -----------------------------------------------------------
> 
> (Updated May 31, 2013, 10:48 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port time_t to QDateTime in KLauncher
> 
> 
> Diffs
> -----
> 
>   kinit/klauncher.h 695ee2c31d655cc2df0e9c23dc36226176f07a90 
>   kinit/klauncher.cpp 2a42f87d4db27de85aff0ff2b68c3c72c2521e69 
> 
> Diff: http://git.reviewboard.kde.org/r/110760/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130603/81d73c40/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list