Review Request 110643: Move KPasswordDialog to tier1/kwidgetaddons
David Edmundson
david at davidedmundson.co.uk
Sun Jun 2 13:24:47 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110643/
-----------------------------------------------------------
(Updated June 2, 2013, 1:24 p.m.)
Review request for KDE Frameworks.
Changes
-------
Address review comments.
Description
-------
Known "bugs"
- there's no clear icon in the text field anymore as I had to port away from KLineEdit
Diff shown is without the actual moving for easier reviewing.
Diffs (updated)
-----
tier1/kwidgetsaddons/src/kpassworddialog.h e554c2a
tier1/kwidgetsaddons/src/CMakeLists.txt df22699
kdeui/CMakeLists.txt 46e08df
kdeui/tests/CMakeLists.txt 5c1f386
tier1/kwidgetsaddons/src/kpassworddialog.cpp 168271c
tier1/kwidgetsaddons/src/kpassworddialog.ui 95845b9
tier1/kwidgetsaddons/tests/CMakeLists.txt de5e6e4
tier1/kwidgetsaddons/tests/kpassworddialogtest.cpp b1c55ee
Diff: http://git.reviewboard.kde.org/r/110643/diff/
Testing
-------
Thanks,
David Edmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130602/1ea63ef5/attachment.html>
More information about the Kde-frameworks-devel
mailing list