Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

Sebastian Kügler sebas at kde.org
Tue Jul 30 19:45:03 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111689/
-----------------------------------------------------------

(Updated July 30, 2013, 7:45 p.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

Thanks for the review. All issues have been addressed in this version.


Description
-------

Small program which takes a .desktop file and converts it to json. This is useful to convert plugins which have their metadata in .desktop files (i.e. all KDE plugins) to Qt's new plugin system.


Diffs (updated)
-----

  staging/kservice/tools/CMakeLists.txt PRE-CREATION 
  staging/kservice/tools/desktoptojson/CMakeLists.txt PRE-CREATION 
  staging/kservice/tools/desktoptojson/kconfigtojson.h PRE-CREATION 
  staging/kservice/tools/desktoptojson/kconfigtojson.cpp PRE-CREATION 
  staging/kservice/tools/desktoptojson/main.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111689/diff/


Testing
-------

Converted metadata of several plugins and used them from QPluginLoader -- works.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130730/e9b60afb/attachment.html>


More information about the Kde-frameworks-devel mailing list