Review Request 111688: QVariantList-based ctor for KPluginInfo

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111688/#review36831
-----------------------------------------------------------



staging/kservice/src/services/kplugininfo.cpp
<http://git.reviewboard.kde.org/r/111688/#comment27169>

    I'd leave these unrelated changes out and do it in a separate cleanup commit. just new code should not need these cleanups afterwards.


- Milian Wolff


On July 30, 2013, 2:41 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111688/
> -----------------------------------------------------------
> 
> (Updated July 30, 2013, 2:41 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> This patch allows KPluginInfo to be created from a QVariantList, as it is typically passed in from KPluginFactory (using the patch which changes the macro there).
> 
> 
> Diffs
> -----
> 
>   staging/kservice/src/services/kplugininfo.h c000008 
>   staging/kservice/src/services/kplugininfo.cpp bd1eaec 
>   staging/kservice/src/services/kservice.h a116e22 
> 
> Diff: http://git.reviewboard.kde.org/r/111688/diff/
> 
> 
> Testing
> -------
> 
> Works with plugins built in the right way: A valid KPluginInfo is created from the plugin's metadata.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130730/94d54575/attachment.html>