Review Request 111688: QVariantList-based ctor for KPluginInfo

[Sebastian Kügler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111688/
-----------------------------------------------------------

(Updated July 30, 2013, 2:31 a.m.)


Review request for KDE Frameworks and David Faure.


Changes
-------

* Moved the argument dance into KService::createInstance(), this way we don't need the extra API in KPluginFactory
* Added more comprehensive apidocs


Description
-------

This patch allows KPluginInfo to be created from a QVariantList, as it is typically passed in from KPluginFactory (using the patch which changes the macro there).


Diffs (updated)
-----

  staging/kservice/src/services/kplugininfo.h c000008 
  staging/kservice/src/services/kplugininfo.cpp bd1eaec 
  staging/kservice/src/services/kservice.h a116e22 

Diff: http://git.reviewboard.kde.org/r/111688/diff/


Testing
-------

Works with plugins built in the right way: A valid KPluginInfo is created from the plugin's metadata.


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130730/3d17d0d6/attachment.html>