Review Request 111702: Move K4AboutData and KComponentData to kde4support

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111702/#review36767
-----------------------------------------------------------

Ship it!


KHTML could be ported away of course, but this can be done in a separate commit.

Just two small things to fix before committing:


kdecore/kernel/kcomponentdata.cpp
<http://git.reviewboard.kde.org/r/111702/#comment27144>

    Actually it's joining kstandarddirs.cpp in kde4support, so it doesn't need to be exported anymore (i.e. remove the KDECORE_EXPORT from kstandarddirs.cpp too)



khtml/CMakeLists.txt
<http://git.reviewboard.kde.org/r/111702/#comment27145>

    Change this to have one library per line (like we're starting to do everywhere else)
    and add a comment after KDE4Support to say why, e.g.
    
        KDE4Support # KComponentData (TODO port to KAboutData)


- David Faure


On July 29, 2013, 4:07 p.m., Andrea Scarpino wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111702/
> -----------------------------------------------------------
> 
> (Updated July 29, 2013, 4:07 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> * Adds a dependence to KDE4Support in KHtml.
> 
> 
> Diffs
> -----
> 
>   kdecore/CMakeLists.txt 8458a4d 
>   kdecore/kernel/k4aboutdata.h f50e750 
>   kdecore/kernel/k4aboutdata.cpp 76b274d 
>   kdecore/kernel/kcomponentdata.h c699870 
>   kdecore/kernel/kcomponentdata.cpp 9bc246f 
>   kdecore/kernel/kcomponentdata_p.h  
>   khtml/CMakeLists.txt 157ec69 
>   kio/misc/ksendbugmail/main.cpp cf17f00 
>   staging/kde4support/src/CMakeLists.txt 24bcff3 
> 
> Diff: http://git.reviewboard.kde.org/r/111702/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Andrea Scarpino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130729/e8e33969/attachment.html>