Review Request 111744: Get rid of kde_file.h in file kioslave + remove unused includes

David Faure faure at kde.org
Sat Jul 27 16:32:08 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111744/#review36609
-----------------------------------------------------------

Ship it!


Ship It!

- David Faure


On July 27, 2013, 4:25 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111744/
> -----------------------------------------------------------
> 
> (Updated July 27, 2013, 4:25 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Removes kde_file.h include and replaces all macros/functions in there with Qt/unix equivalents.
> 
> 
> Diffs
> -----
> 
>   kioslave/file/file.cpp 115b919 
>   kioslave/file/file_unix.cpp 64cffa0 
> 
> Diff: http://git.reviewboard.kde.org/r/111744/diff/
> 
> 
> Testing
> -------
> 
> Kioslave builds, all tests passes.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/750f8d69/attachment.html>


More information about the Kde-frameworks-devel mailing list