Review Request 111724: Port file kioslave rename() to QFile

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111724/
-----------------------------------------------------------

(Updated July 27, 2013, 4:19 p.m.)


Status
------

This change has been discarded.


Review request for KDE Frameworks.


Description
-------

Ports KDE_rename(..) to QFile::rename(..). All tests pass except those where moving dirs between partitions occur. The Qt4 docs says "rename will fail if newName and oldName are not on the same partition" for QDir::rename(); there's no such mention in Qt 5.dev docs but it still seems to be the case and I'm unsure what to do, please advise.


Diffs
-----

  kioslave/file/file_unix.cpp 64cffa0 

Diff: http://git.reviewboard.kde.org/r/111724/diff/


Testing
-------

All tests pass except moving dirs between partitions.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/c3a0c503/attachment.html>