Review Request 111701: Port away from kde_file in KDirOperator (KFile)

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111701/#review36585
-----------------------------------------------------------



kfile/kdiroperator.cpp
<http://git.reviewboard.kde.org/r/111701/#comment26989>

    Given the old implementation, I suspect that this method is called for directories, not files.
    I'm not sure this code is portable to e.g. Windows.
    
    QDir(url.toLocalFile()).isReadable() seems more appropriate?


- David Faure


On July 25, 2013, 9:45 p.m., David Gil Oliva wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111701/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 9:45 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Port away from kde_file in KDirOperator (KFile)
> 
> REVIEW: 111701
> 
> 
> Diffs
> -----
> 
>   kfile/kdiroperator.cpp d4da9eb775fc8b3d2a8e035d82ebfb8d89b9aa5d 
> 
> Diff: http://git.reviewboard.kde.org/r/111701/diff/
> 
> 
> Testing
> -------
> 
> It builds.
> 
> 
> Thanks,
> 
> David Gil Oliva
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130727/ebbd091a/attachment-0001.html>