Review Request 111678: Fix not found sonnet(core|ui)_export.h

[Martin Gräßlin]

> On July 25, 2013, 6:18 p.m., Alexander Neundorf wrote:
> > Out of interest: was it obvious for you that you have to add some parameter to the generate_export_header() call or was it kind of hard to figure out where that header file is coming from ?

figuring out where the file is coming from was not that difficult. I saw it in the build directory, I saw the include path and figured out that this doesn't match, that the header file cannot be found. As the CMakeLists.txt was not that long I figured out where it's generated - the method does what it's called :-) After that it was just an RTFM and find an appropriate solution.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111678/#review36496
-----------------------------------------------------------


On July 25, 2013, 2:38 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111678/
> -----------------------------------------------------------
> 
> (Updated July 25, 2013, 2:38 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> 0d5e8a432b7b63357696dbf2fbed5633919bff6b adjusted the include path for the export file to be sonnet/sonnetfoo_export.h in the public header files. This broke the build as those files cannot be found in the current build directory.
> 
> To solve this problem the export files are now generated in a sub-directory sonnet, so that the path matches. In addition the includes in the private headers are adjusted to also look for sonnet/ so that they can find it.
> 
> 
> Diffs
> -----
> 
>   tier1/sonnet/src/core/CMakeLists.txt 7f6384a 
>   tier1/sonnet/src/core/client_p.h d168f1f 
>   tier1/sonnet/src/core/filter_p.h 783a920 
>   tier1/sonnet/src/core/loader_p.h f505510 
>   tier1/sonnet/src/core/settings_p.h 639a503 
>   tier1/sonnet/src/core/spellerplugin_p.h 81eb9b8 
>   tier1/sonnet/src/ui/CMakeLists.txt 7abbb73 
> 
> Diff: http://git.reviewboard.kde.org/r/111678/diff/
> 
> 
> Testing
> -------
> 
> compiles and installs
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20130726/fa099b04/attachment.html>